search

f-f / gogolica

Auto-generated Google APIs for Clojure
Eclipse Public License 1.0
2 stars 0 forks source link

Json shouldn't be converted to kebab case #18

Closed f-f closed 6 years ago

f-f commented 6 years ago

We shouldn't be converting all the model json to kebab case. While it is nicer and more idiomatic to do destructuring with it, Google APIs expect parameters to be passed in with their syntax in requests.

The following code is being generated now:

image

While we could of course convert back the parameters to CamelCase, it might be that the conversion is not lossless, and I don't feel safe doing CamelCase -> kebab-case -> CamelCase.

f-f commented 6 years ago

Which makes me think that we should have integration tests (aka actually hitting Google APIs and doing stuff) ASAP.