f-f / purescript-react-basic-native

Apache License 2.0
60 stars 18 forks source link

Upgrade purs to 0.13 and expo to 34 #22

Closed andywhite37 closed 4 years ago

andywhite37 commented 4 years ago

Hi @dwhitney!

It's a blast from the Pellucid past! Thanks for making this library, I just got it all upgraded and working and I'm excited to play around with it. This looks like a real labor of love, so thanks for taking the time to figure all this stuff out. Are you still viewing this repo as a good approach for cross-platform mobile apps in PureScript, or have you moved onto something else at this point?

For this PR, I updated spago stuff, npm libs, etc. and I also added the expo start:web stuff to allow apps to be previewed via web. The examples both have a new npm run web command to run that.

dwhitney commented 4 years ago

Hey Andy! I saw this over the weekend but them forgot about it - apologies for the late response.

I'll take a look at this PR tonight, but I don't foresee any issues. BTW, I am working with Earle now and in about a month we're going to kick off a project that will use this quite a bit. I may make some changes to it - like breaking the library out into multiple files, etc.

f-f commented 4 years ago

@dwhitney I was looking into this project for a mobile app, are the improvements you mention above still happening? If yes, I'll wait for them, otherwise it looks like I could work off this branch?

dwhitney commented 4 years ago

I have no idea when I'll get around to looking at this, so go ahead and do whatever you want. I'm happy to transfer ownership of you want too

D

On Thu, Mar 26, 2020, 12:58 PM Fabrizio Ferrai notifications@github.com wrote:

@dwhitney https://github.com/dwhitney I was looking into this project for a mobile app, are the improvements you mention above still happening? If yes, I'll wait for them, otherwise it looks like I could work off this branch?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dwhitney/purescript-react-basic-native/pull/22#issuecomment-604547773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIFIM63WW5J5VUI5YJVEDRJOCSZANCNFSM4KEDFFXA .

andywhite37 commented 4 years ago

For what it's worth, I would consider this PR to be fairly safe to merge. All I did was update some of the library versions, and migrate the spago files into the more recent way of doing things.

I was able to get everything compiling and running locally.

Looking at the PR again, one thing that might need a bit more attention is the use of yarn vs. npm. I think you maybe originally used yarn, and I used npm for no particular reason. I think we'd just want to delete either the package-lock.json or the yarn.lock, and make sure the one that is kept is up-to-date. It seems that people prefer yarn these days, so maybe that's best.

FranklinChen commented 4 years ago

I'm curious what the general status of this project is.

dwhitney commented 4 years ago

Well it works, but I'm not sure I'll have much time to work on it. I'm happy to give it up to someone else.

On Sat, Apr 11, 2020 at 9:13 PM Franklin Chen notifications@github.com wrote:

I'm curious what the general status of this project is.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dwhitney/purescript-react-basic-native/pull/22#issuecomment-612546782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIFIMLKYVWOEKID3EM5BTRMEIR7ANCNFSM4KEDFFXA .

f-f commented 4 years ago

@dwhitney it looks like community interest in this stuff is quite consistent so I wouldn't like this to feel abandoned - I guess I could take on commit access (or admin/ownership if you want to get rid of it) to merge pending PRs and update this otherwise. How does this sound?

dwhitney commented 4 years ago

Hey yeah that would be awesome! Sorry for the late reply. I lost my job during this dumb pandemic. Searching for a job while homeschooling two kids has me feeling like I'm drowning.

D

On Tue, Apr 21, 2020 at 5:17 AM Fabrizio Ferrai notifications@github.com wrote:

@dwhitney https://github.com/dwhitney it looks like community interest in this stuff is quite consistent so I wouldn't like this to feel abandoned

  • I guess I could take on commit access (or admin/ownership if you want to get rid of it) to merge pending PRs and update this otherwise. How does this sound?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dwhitney/purescript-react-basic-native/pull/22#issuecomment-617059467, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIFIJNAHZUABV4IJ4VHFTRNVQDHANCNFSM4KEDFFXA .

dwhitney commented 4 years ago

I'll transfer access in a bit.

On Tue, Apr 21, 2020 at 3:28 PM Dustin Whitney dustin.whitney@gmail.com wrote:

Hey yeah that would be awesome! Sorry for the late reply. I lost my job during this dumb pandemic. Searching for a job while homeschooling two kids has me feeling like I'm drowning.

D

On Tue, Apr 21, 2020 at 5:17 AM Fabrizio Ferrai notifications@github.com wrote:

@dwhitney https://github.com/dwhitney it looks like community interest in this stuff is quite consistent so I wouldn't like this to feel abandoned

  • I guess I could take on commit access (or admin/ownership if you want to get rid of it) to merge pending PRs and update this otherwise. How does this sound?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dwhitney/purescript-react-basic-native/pull/22#issuecomment-617059467, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIFIJNAHZUABV4IJ4VHFTRNVQDHANCNFSM4KEDFFXA .

f-f commented 4 years ago

@dwhitney no worries at all for the delay, and thank you for sharing where you're at - indeed this global reshuffling is hitting quite hard pretty much everyone. I'm sorry to hear you lost your job and wish you all the best to navigate the next months, hopefully we'll get out of this soon :slightly_smiling_face: :heart:

f-f commented 4 years ago

Thanks again @dwhitney!

@andywhite37 this looks great to me, merging :slightly_smiling_face: