search

f-klubben / sangbog

6 stars 7 forks source link

Songs on the right pages of the booklet are occasionally getting too close to the margin #44

Open JakobTopholt opened 2 months ago

JakobTopholt commented 2 months ago

Looking at page 23, 31, 41 of the PDF you will witness text "overflowing"

JakobTopholt commented 2 months ago

Achieved when building with nix

JakobTopholt commented 2 months ago

perhaps this? @Mast3rwaf1z https://github.com/f-klubben/sangbog/commit/5909fb3203c90b7957ec49e39a588e54a822e445

JakobTopholt commented 2 months ago

In the interest of not yapping too much I'll look at this later.

krestenlaust commented 2 months ago

When you say "yap" you mean "commenting" right?

JakobTopholt commented 2 months ago

I'm mostly referring to commenting my first thought every time it comes across, rather than writing a single comment in which only relevant information is found.

Mast3rwaf1z commented 2 months ago

perhaps this? @Mast3rwaf1z 5909fb3

This was because we were using an ancient version of (ghostscript?), but updating CI broke it.

I'll take a look later

Mast3rwaf1z commented 2 months ago

perhaps this? @Mast3rwaf1z 5909fb3

I wish you would just use squash... this commit was very misleading because i undid a previous change in the same PR...

anyway i've looked through both the booklet and the pdf, and it seems the issue is happening in the booklet right? the booklet does not use the flag that i changed in that PR, so that is also not what is causing the issue.

A side note is that an issue just appearing like this gives me the impression that its probably due to the updated dependencies.

EDIT: action seems to have been changed back to the older dependencies, confirming that its probably due to an update. if you check the artifact from action: https://github.com/f-klubben/sangbog/actions/runs/9800137287/artifacts/1669365391 it looks correct.

JakobTopholt commented 2 months ago

Ty I'll take a look.

JakobTopholt commented 2 months ago

I can confirm that it looks perfect when built through debian, so it's not the biggest hurry to fix it for nix.

Mast3rwaf1z commented 2 months ago

Neither am I, you know how fast that script was written :P

JakobTopholt commented 2 months ago

Anyway, the issue remains, but as long as building through Debian works it won't be a high priority for me to figure out why it doesn't quite work with Nix.