search

f-klubben / stregsystemet

The very public stregsystem repo
Other
37 stars 47 forks source link

Remove hardcoded mailserver & -address #187

Open joandrsn opened 4 years ago

joandrsn commented 4 years ago

Came from PR #185. Currently there are lines of codes like these:

https://github.com/f-klubben/stregsystemet/blob/babdef240deee76ec294265d20fdebd618e2da55/stregsystem/utils.py#L113-L114 and https://github.com/f-klubben/stregsystemet/blob/babdef240deee76ec294265d20fdebd618e2da55/stregsystem/utils.py#L83

In order to make the application more flexible, there could be a config file with the information.

krestenlaust commented 10 months ago

@falkecarlsen this issue should be reopened, as #340 didn't resolve it anyway

krestenlaust commented 10 months ago

The mail code has since been refactored (#335, #340 )

The new location of the hardcoded mailserver and -address is

https://github.com/f-klubben/stregsystemet/blob/fafb3ac6b1eee876fb5c8fdf9e83cc119b5c3d8b/stregsystem/mail.py#L35C14-L35C14

and https://github.com/f-klubben/stregsystemet/blob/fafb3ac6b1eee876fb5c8fdf9e83cc119b5c3d8b/stregsystem/mail.py#L45-L46