f-klubben / stregsystemet

The very public stregsystem repo
Other
37 stars 47 forks source link

Kiosk items are still active after their end date #426

Open miniJmo opened 2 months ago

miniJmo commented 2 months ago

So they are not shown on the slideshow, but on the admin panel, they still have the green checkmark after their end date.

krestenlaust commented 2 months ago

Would adding another property "displayed" satisfy your issue?

The active state is an independent setting on each kiosk entry

miniJmo commented 2 months ago

Would adding another property "displayed" satisfy your issue?

The active state is an independent setting on each kiosk entry

What I am asking for is basically this if date >= endDate then kioskItem.active(false);

krestenlaust commented 2 months ago

I'm not sure that's a good idea, that would reduce functionality. What if you manually disable it while it is in an active period. And what if you activate it after it's ended. I don't think there's any logical behavior in such situations

krestenlaust commented 2 months ago

Otherwise we should remove the active functionality entirely and only allow items to be set with dates, but that would also be a little silly

miniJmo commented 2 months ago

If you have to be such a party pooper then I will just deactivate them manually😢

krestenlaust commented 2 months ago

I'll probably just implement ot my way ;)