f-lab-clone / ticketing-backend

[2023] Ticketing Service - PerformanceTest, Terraform, EKS, Grafana
https://github.com/f-lab-clone/ticketing-infra
5 stars 3 forks source link

refactor: make signin format same with SuccessResponseDTO #123

Closed minjun3021 closed 1 year ago

minjun3021 commented 1 year ago

What is this PR?

Key Changes

Filter단 에서 request처리가 끝나 ResponseAdvice에 적용을을 못받는 엔드포인트에 대해 SuccessResponseDTO 형식을 수동으로 맞추어줌

Test Checklist

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (c4ba6df) 84.63% compared to head (3d3d9ff) 84.69%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #123 +/- ## ============================================ + Coverage 84.63% 84.69% +0.06% Complexity 152 152 ============================================ Files 42 42 Lines 729 732 +3 Branches 31 31 ============================================ + Hits 617 620 +3 Misses 91 91 Partials 21 21 ``` | [Files](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone) | Coverage Δ | | |---|---|---| | [...ticketingservice/filter/JwtAuthenticationFilter.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9maWx0ZXIvSnd0QXV0aGVudGljYXRpb25GaWx0ZXIua3Q=) | `92.00% <100.00%> (+1.09%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.