f-lab-clone / ticketing-backend

[2023] Ticketing Service - PerformanceTest, Terraform, EKS, Grafana
https://github.com/f-lab-clone/ticketing-infra
5 stars 3 forks source link

Feat/54 reservation concurrency #71

Closed minjun3021 closed 1 year ago

minjun3021 commented 1 year ago

What is this PR?

동시 작업을 처리하는 스레드 풀을 생성하여 reservation 를 테스트 하였으나

expected: 100L but was: 104L

제한을 넘어가는 현상발생 concurrency 관련 작업이 필요함

Key Changes

Test Checklist

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 71.42% and project coverage change: -0.34% :warning:

Comparison is base (d51d4a8) 81.27% compared to head (6feb018) 80.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #71 +/- ## ============================================ - Coverage 81.27% 80.94% -0.34% - Complexity 126 127 +1 ============================================ Files 36 36 Lines 502 509 +7 Branches 24 26 +2 ============================================ + Hits 408 412 +4 - Misses 74 75 +1 - Partials 20 22 +2 ``` | [Files Changed](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone) | Coverage Δ | | |---|---|---| | [...up4/ticketingservice/service/ReservationService.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9zZXJ2aWNlL1Jlc2VydmF0aW9uU2VydmljZS5rdA==) | `75.00% <57.14%> (-4.17%)` | :arrow_down: | | [...kotlin/com/group4/ticketingservice/entity/Event.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9lbnRpdHkvRXZlbnQua3Q=) | `93.75% <80.00%> (-6.25%)` | :arrow_down: | | [.../com/group4/ticketingservice/entity/Reservation.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/71?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9lbnRpdHkvUmVzZXJ2YXRpb24ua3Q=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

junha-ahn commented 1 year ago

Generate OpenAPI Document 버그 해결을 위해 Main Branch 내용 한번 받아오세요 #70