f-lab-clone / ticketing-backend

[2023] Ticketing Service - PerformanceTest, Terraform, EKS, Grafana
https://github.com/f-lab-clone/ticketing-infra
5 stars 3 forks source link

Feat/52 advanced-api-jwt #76

Closed ParkJeongseop closed 1 year ago

ParkJeongseop commented 1 year ago

What is this PR?

Key Changes

Test Checklist

junha-ahn commented 1 year ago

@minjun3021 님이 처리해주시면 됩니다)

그 후 https://github.com/f-lab-clone/ticketing-backend/issues/52#issuecomment-1689941947 순서에 맞게 구현 (각각을 다른 브랜치로 구현)

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 92.68% and project coverage change: +0.53% :tada:

Comparison is base (61d1ddc) 80.94% compared to head (2e46fbf) 81.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #76 +/- ## ============================================ + Coverage 80.94% 81.48% +0.53% + Complexity 127 119 -8 ============================================ Files 36 36 Lines 509 459 -50 Branches 26 27 +1 ============================================ - Hits 412 374 -38 + Misses 75 62 -13 - Partials 22 23 +1 ``` | [Files Changed](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone) | Coverage Δ | | |---|---|---| | [...up4/ticketingservice/controller/EventController.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9jb250cm9sbGVyL0V2ZW50Q29udHJvbGxlci5rdA==) | `100.00% <ø> (ø)` | | | [...com/group4/ticketingservice/utils/TokenProvider.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS91dGlscy9Ub2tlblByb3ZpZGVyLmt0) | `48.21% <0.00%> (ø)` | | | [...up4/ticketingservice/service/ReservationService.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9zZXJ2aWNlL1Jlc2VydmF0aW9uU2VydmljZS5rdA==) | `74.07% <71.42%> (-0.93%)` | :arrow_down: | | [.../ticketingservice/controller/BookmarkController.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9jb250cm9sbGVyL0Jvb2ttYXJrQ29udHJvbGxlci5rdA==) | `86.66% <100.00%> (+0.95%)` | :arrow_up: | | [...cketingservice/controller/ReservationController.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9jb250cm9sbGVyL1Jlc2VydmF0aW9uQ29udHJvbGxlci5rdA==) | `100.00% <100.00%> (ø)` | | | [...oup4/ticketingservice/controller/UserController.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9jb250cm9sbGVyL1VzZXJDb250cm9sbGVyLmt0) | `100.00% <100.00%> (ø)` | | | [...com/group4/ticketingservice/dto/BookmarkFromdto.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9kdG8vQm9va21hcmtGcm9tZHRvLmt0) | `100.00% <100.00%> (ø)` | | | [.../com/group4/ticketingservice/dto/ReservationDto.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9kdG8vUmVzZXJ2YXRpb25EdG8ua3Q=) | `100.00% <100.00%> (ø)` | | | [...lin/com/group4/ticketingservice/entity/Bookmark.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9lbnRpdHkvQm9va21hcmsua3Q=) | `100.00% <100.00%> (ø)` | | | [...kotlin/com/group4/ticketingservice/entity/Event.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9lbnRpdHkvRXZlbnQua3Q=) | `100.00% <100.00%> (+6.25%)` | :arrow_up: | | ... and [5 more](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/76/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ParkJeongseop commented 1 year ago

컨플릭트만 해결하면 될것같습니다.