search

f-lab-clone / ticketing-backend

[2023] Ticketing Service - PerformanceTest, Terraform, EKS, Grafana
https://github.com/f-lab-clone/ticketing-infra
5 stars 3 forks source link

Feat/39 time convention #90

Closed minjun3021 closed 1 year ago

minjun3021 commented 1 year ago

What is this PR?

Key Changes

시간관련 기준을 모두 (UTC+00:00)로 통일함

위의 작업을 함으로써 #55 에서 request를 parse할때 UTC시간으로 컨버트하는 작업을 없에고 디비에 저장될때 자동으로 되게함

OffsetDateTime을 사용함으로 시간관련 요청의 형식은

2023-09-19T00:46:00+09:00 2023-09-18T15:46:00Z

이런식으로 할수있음

Test Checklist

minjun3021 commented 1 year ago

request 예시

같은시각을 UTC+00:00인 시간과 UTC+00:00이 아닌 시간을 요청보내도 DB에 일관되게 저장되는 모습

*reservationStartTime,reservationEndTime 필드 참고

minjun3021 commented 1 year ago

integration test

기존 time 관련 테스트도 통과

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 87.09% and project coverage change: -0.42% :warning:

Comparison is base (15d6b8b) 81.79% compared to head (1f492f2) 81.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #90 +/- ## ============================================ - Coverage 81.79% 81.38% -0.42% + Complexity 121 116 -5 ============================================ Files 36 35 -1 Lines 467 478 +11 Branches 27 25 -2 ============================================ + Hits 382 389 +7 - Misses 62 67 +5 + Partials 23 22 -1 ``` | [Files Changed](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone) | Coverage Δ | | |---|---|---| | [...n/com/group4/ticketingservice/config/GsonConfig.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9jb25maWcvR3NvbkNvbmZpZy5rdA==) | `0.00% <ø> (ø)` | | | [...m/group4/ticketingservice/config/TimeZoneConfig.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9jb25maWcvVGltZVpvbmVDb25maWcua3Q=) | `0.00% <0.00%> (ø)` | | | [...up4/ticketingservice/controller/EventController.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9jb250cm9sbGVyL0V2ZW50Q29udHJvbGxlci5rdA==) | `100.00% <100.00%> (ø)` | | | [.../kotlin/com/group4/ticketingservice/dto/UserDto.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9kdG8vVXNlckR0by5rdA==) | `100.00% <100.00%> (ø)` | | | [...m/group4/ticketingservice/entity/BaseTimeEntity.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9lbnRpdHkvQmFzZVRpbWVFbnRpdHkua3Q=) | `100.00% <100.00%> (ø)` | | | [...lin/com/group4/ticketingservice/entity/Bookmark.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9lbnRpdHkvQm9va21hcmsua3Q=) | `100.00% <100.00%> (ø)` | | | [...kotlin/com/group4/ticketingservice/entity/Event.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9lbnRpdHkvRXZlbnQua3Q=) | `100.00% <100.00%> (ø)` | | | [...om/group4/ticketingservice/service/EventService.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9zZXJ2aWNlL0V2ZW50U2VydmljZS5rdA==) | `100.00% <100.00%> (ø)` | | | [...up4/ticketingservice/service/ReservationService.kt](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone#diff-c3JjL21haW4va290bGluL2NvbS9ncm91cDQvdGlja2V0aW5nc2VydmljZS9zZXJ2aWNlL1Jlc2VydmF0aW9uU2VydmljZS5rdA==) | `73.07% <100.00%> (-1.00%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/f-lab-clone/ticketing-backend/pull/90/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=f-lab-clone)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.