search

f-list / fserv

Repository for the F-Chat server implementation.
BSD 2-Clause "Simplified" License
10 stars 5 forks source link

Normalize in channel checks. #30

Open kiranoot opened 10 years ago

kiranoot commented 10 years ago

Currently you may kick/unban/op/deop/set owner a user without being present in the channel, but may not ban/timeout a user.

Either all of these should check for being in the channel, or the restriction should be removed from ban/timeout.

Dhwty commented 10 years ago

I'm going to vote for removing the restriction. Cuts down on those times when you kick a user and then go 'Damn, I should've banned them'.

In-channel restrictions are (or at least were) enforced on adding/removing chanops, clientside, in the web clients. Not a server issue, but something to be aware of during testing.

kiranoot commented 10 years ago

I should clarify that these limits are for you and not for the target character.

princesstrash commented 10 years ago

This might be able to help with this, but I have to have someone else look at the logic to make sure I'm doing it properly.