search

f-list / fserv

Repository for the F-Chat server implementation.
BSD 2-Clause "Simplified" License
10 stars 5 forks source link

Per channel configuration options. #35

Open kiranoot opened 10 years ago

kiranoot commented 10 years ago

Allow for the disabling of dice and bottle in channels, and potentially other standard features.

princesstrash commented 9 years ago

What else would be disable-able, if we were you exhaust the list? I can't think of much else.

kiranoot commented 9 years ago

Bottle, Dice, Ad timer length in seconds, message throttle in seconds(lower limit of global default), Maximum ad length(upper limit of global maximum), chat message maximum length(upper limit of global maximum).

princesstrash commented 9 years ago

I see. Any message/event this should be apart of specifically, or shall I create a new one?

kiranoot commented 9 years ago

A new message should be created so it does not overlap with previous features. CSO (Channel Set Option) is a suggestion, and CGO (Channel Get Option/s) to keep with the current naming convention for messages.

princesstrash commented 9 years ago

Should "description" be considered a channel option?

kiranoot commented 9 years ago

I don't believe it offers any benefit to combine the description into this. Adding the channel posting mode(ads/chat/both) into this would however be helpful.

WreckedAvent commented 9 years ago

If you roll the channel opening/closing into this I will be happy. Right now it's based off of SYS and involves parsing strings:

https://github.com/WreckedAvent/slimCat/blob/master/slimCat/Commands/System/MessageCommand.cs#L38 https://github.com/WreckedAvent/slimCat/blob/master/slimCat/Commands/Channel/TypeCommand.cs#L56

princesstrash commented 9 years ago

That sounds like it should be a separate Channel Notification message?

I was thinking something along the lines of CCO, Channel Changed Notification (a realtime event whenever a channel option is changed or closed or opened). CSO, at the moment, will probably echo back a message to the user that issued the change message so that will allow a person to know if their Channel Set Option command succeeded.

princesstrash commented 9 years ago

Fixed here, including @WreckedAvent 's issues. The old sys message will still be sent, but a CSO message will always be echoed back, even if an RST message is sent