Open boopcat opened 8 years ago
I'm not that bothered by a lack of PCH. The total build time is low enough that it shouldn't be of major impact.
The project is vaguely structured around the precompiled_headers.hpp
header. What'd be a better name for that, if it's renamed at all?
Code looks good, and the licenses appear to be compatible with the BSD license of the chat server.
Is there a way to include Cotire without placing it in the repo directly? Perhaps through a git subtree, or through a travis step? My main objection to the previous set up was that it was included as part of the repo directly.
A subtree is part of the repo, just easily updated to an external repo. A submodule is possible. Travis step is also reasonable, but I'll need to double check to make sure I can conditionally run cotire.
If it can be easily pulled in, and isn't part of the repo, it doesn't need to be conditional. Having it conditional might be useful, but isn't a requirement.
We'll see how travis likes it, but this should make cotire an optional, submodule-ed dep.
It doesn't. Looks like it's because I'm using an ssh url for the submodule. Fixing.
Just putting this up to get more feedback on it.
Now compiles on systems with recent gperftools! Woo!
Currently this doesn't do precompiled headers, there's a CMake module that works great for them but it was deemed a bit much to be adding.
Current todo: