search

f-miyu / Plugin.CloudFirestore

MIT License
121 stars 44 forks source link

Opposite merge flag meaning for Batch.Set and Transaction.Set method in Android Wrapper #98

Open weinamdev opened 2 years ago

weinamdev commented 2 years ago

Hi there,

I found the merge flag for Set method in both Transaction and Batch in Android wrapper carry opposite meaning as compared to Document.SetAsync, which is consistent with Firebase official documentations.

However, Batch.Set and Transaction.Set in iOS wrapper working fine, and performing consistently with Document.SetAsync definition.

Expected Behavior: When Merge = true, only replace the affected fields

Actual Behavior: In Android Wrapper, Merge flag in batch write and transaction works in opposite way, hence when Merge = false only replaces affected field, and Merge = true replace the entire document

Thank you.

ccgould commented 10 months ago

Surprised this hasn't been fixed yet.