search

f-o-a-m / kepler

A Haskell framework that facilitates writing ABCI applications
https://kepler.dev
Apache License 2.0
34 stars 10 forks source link

Move metrics to central location to be used by middleware and app #180

Closed martyall closed 4 years ago

martyall commented 4 years ago

We want to remove the dependence on the datadog katip cribe and use prometheus for everything. This means that we'll need to move metrics stuff from the SDK into a common place

IvantheTricourne commented 4 years ago

You are referring to this scribe?

https://github.com/f-o-a-m/hs-abci/blob/master/hs-abci-extra/src/Network/ABCI/Server/Middleware/MetricsLogger.hs#L42

Does this mean we're removing the metrics effect?

martyall commented 4 years ago

No we're removing the datadog katip scribe from the middleware and using prometheus everywhere

martyall commented 4 years ago

The SDK will stay as it is, except that the metrics core types will get moved to a common place