Inconsistent types in tendermint RPC

IvantheTricourne commented 4 years ago

Related to #75.

Missing Fields

Type definitions with fields that are missing when uninitialized

Info: last_block_height and last_block_app_hash

Null Fields

Type definitions with fields that are set to null when uninitialized

String Fields

Type definitions with fields typed "string" (i.e., wrappers over number types)

Client.hs

Vote: height, round and index
ResultTx: height
RequestBlock: height_ptr
RequestABCIQuery: height

Response.hs

DeliverTx: gas_wanted and gas_used
CheckTx: gas_wanted and gas_used
Query: height and index
Info: height and app_version

Request.hs

EndBlock: height
Query: height

FieldTypes.hs

Evidence: height and total_voting_power
Header: height, num_txs, and total_txs
Version: block and app
PartSetHeader: total
LastCommitInfo: round
Validator: power
ValidatorUpdate: power
EvidenceParams: max_age
BlockParams: max_bytes and max_gas

Types.hs

QueryResult: height and index
QueryArgs: block_height

martyall commented 4 years ago

related to #109

alexfmpe commented 4 years ago

Edit: Ok, this was resolved by bumping kepler, so I think it can be ignored.

I'm running into

*** Exception: ParsingException "parsing Word64 failed, expected Number, but encountered String"

when trying to use RPC.abciInfo even though manually curling works

{
  "jsonrpc": "2.0",
  "id": "",
  "result": {
    "response": {
      "data": "1",
      "version": "123",
      "app_version": "1",
      "last_block_height": "123"
    }
  }
}

I see this was erroring as of https://github.com/f-o-a-m/kepler/pull/84/commits/92b3b4c3af88a80cbafc5927947464dc03b32c3f.

I'm currently depending on an older version than that, and was wondering if bumping Kepler would fix this.

It seems to work in current Travis? https://travis-ci.com/github/f-o-a-m/kepler/jobs/310896828

RPC Request
{
    "jsonrpc": "2.0",
    "params": [],
    "method": "abci_info",
    "id": 2149148217020253723
}
RPC Response
{
    "result": {
        "response": {
            "data": "{\"size\":0}",
            "app_version": "1",
            "version": "0.16.1"
        }
    },
    "jsonrpc": "2.0",
    "id": 2149148217020253696
}
    Can query /abci_info and parse the result

martyall commented 4 years ago

Yeah this kind of stuff was always a pain to get right, we only lazily discover these kinds of errors. Let me know if you're problem wasn't actually fixed by the bump

f-o-a-m / kepler