f-o-a-m / purescript-web3

a purescript library for the web3 api
Apache License 2.0
127 stars 24 forks source link

Value should be newtype over `UInt 256` instead of BigNumber #113

Closed safareli closed 3 years ago

martyall commented 5 years ago

i'm actually going to go ahead and say "no" on on this one, for similar reasons that we had disagreements with the other hs-web3 maintainers. If you do this then for example you will make the Transaction type depend on the Solidity modules, which is just an inversion of dependencies.

If you want the conversion from BigNumber to Value to fail because of a size or positivity issue, that's still worth talking about. You could also provide an iso somewhere, perhaps in the UInt module.