search

f-o-a-m / purescript-web3

a purescript library for the web3 api
Apache License 2.0
127 stars 24 forks source link

calling `combineEncodedValues` more than once is inefficient #35

Closed martyall closed 6 years ago

martyall commented 6 years ago

the reason this is currently done is to compute current total offset as we're building up the encoding, there's clearly a more efficient way of doing this even if this still produces correct results

martyall commented 6 years ago

this got fixed with 62ca68e671a3ac84520da6f921c509e5b0aef8cb, it turns out we didn't need to do it even once