Mixed case & odd length HexStrings

f-o-a-m / purescript-web3

a purescript library for the web3 api

Apache License 2.0

127 stars 24 forks source link

Mixed case & odd length HexStrings #47

Closed XertroV closed 6 years ago

XertroV commented 6 years ago

[x] Add test for mixed case HexStrings
[x] Add test for odd-lengthed HexStrings
[x] Implement solution for mixed case
[x] Implement soln for odd-lengthed
[x] Add toLower to Eq instance of HexString

Fixes #45

XertroV commented 6 years ago

@blinky3713 & @kejace - have finished this PR

martyall commented 6 years ago

Hey @XertroV this looks good. Can we go ahead and get the proper equality done in this pr where equality is checked on lower case values like you suggested? Or maybe it's not needed? I notice that you are making them lower case in mkHexString, but is it possible that they could enter into the system otherwise?

XertroV commented 6 years ago

Yeah probs good idea. Ethereum might return checksummed addresses sometimes and not others, for example. Since we deserialize automagically we want toLower in the eq instance too.

XertroV commented 6 years ago

@blinky3713 - fixed up Eq HexString now.