f-silva-archaeo / skyscapeR

skyscapeR: an R package for data reduction, visualization and analysis in skyscape archaeology, archaeoastronomy and cultural astronomy.
4 stars 1 forks source link

eq.to.hor #5

Closed vreijs closed 5 years ago

vreijs commented 5 years ago

In stars.R there are two references to eq.to.hor, but this is not defined (as a value).

Sun.alt <- parallel::parApply(cl, X, 1, eq.to.Hor, lat=lat, lon=lon)
...
Star.alt <- parallel::parApply(cl, X, 1, eq.to.Hor, lat=lat, lon=lon)

There is a function eq.to.hor, but in the above code there are no arguments ... Cna you help me to understand what is needed?

f-silva-archaeo commented 5 years ago

Hi Victor

parApply takes a function, in this case eq.to.Hor, and applies it to all elements of X using parallelisation.

So yes in this case it is calling function eq.to.Hor()

Fabio Silva, PhD

Research Associate, UCL Institute of Archaeology

Tutor, Sophia Centre for the Study of Cosmology in Culture, University of Wales Trinity Saint David

Secretary, European Society for Astronomy in Culture (SEAC)

Co-Founder and Co-Editor, Journal of Skyscape Archaeologyhttp://equinoxpub.com/JSA (JSA)

Website/Blog: skyscaper.nethttp://www.skyscaper.net.  Twitter: @fsilva_archaeohttps://twitter.com/fsilva_archaeo

On 26 Sep 2018, 12:43 AM +0200, Victor Reijs notifications@github.com, wrote:

In stars.R there are two references to eq.to.hor, but this is not defined (as a value).

Sun.alt <- parallel::parApply(cl, X, 1, eq.to.Hor, lat=lat, lon=lon) ... Star.alt <- parallel::parApply(cl, X, 1, eq.to.Hor, lat=lat, lon=lon)

There is a function eq.to.hor, but in the above code there are no arguments ... Cna you help me to understand what is needed?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/f-silva-archaeo/skyscapeR/issues/5, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASTOUuNGribB-3c2tQIxpQPUeKLu1q2Eks5uerGBgaJpZM4W5moB.

vreijs commented 5 years ago

On 26 September 2018 at 07:49, Fabio Silva notifications@github.com wrote:

parApply takes a function, in this case eq.to.Hor, and applies it to all elements of X using parallelisation.

So yes in this case it is calling function eq.to.Hor()

Still have to get used to the interpreter languages, I did not 'source' that R-file and then R can't find it;-) But now I get another error (eq2horFS not found, while I can call it myself!) so I must have something wrong in my code (I don't get that error using your R code). So working on it;-).

By the way about the color. I found an error in the SIMBAD search engine (they now repaired that), but I also asked them which of the two: 'B-V' (Color Index) or Spectral Class is best to use as proxy to naked eye color experience on Earth. No answer yer, but do you have an answer to that question? For me it is important in determining what I need to ask from SE-authors.

All the best,

Victor

f-silva-archaeo commented 5 years ago

That’s odd. Hope you can sort that.

Regarding B-V or Spectral class, I’m sure you are familiar with this: http://www.atnf.csiro.au/outreach/education/senior/astrophysics/photometry_colour.html

So maybe B-V is more useful since it encapsulates more information than mere spectral class.

Fabio Silva, PhD

Research Associate, UCL Institute of Archaeology

Tutor, Sophia Centre for the Study of Cosmology in Culture, University of Wales Trinity Saint David

Secretary, European Society for Astronomy in Culture (SEAC)

Co-Founder and Co-Editor, Journal of Skyscape Archaeologyhttp://equinoxpub.com/JSA (JSA)

Website/Blog: skyscaper.nethttp://www.skyscaper.net.  Twitter: @fsilva_archaeohttps://twitter.com/fsilva_archaeo

On 26 Sep 2018, 12:09 +0200, Victor Reijs notifications@github.com, wrote: On 26 September 2018 at 07:49, Fabio Silva notifications@github.com wrote:

parApply takes a function, in this case eq.to.Hor, and applies it to all elements of X using parallelisation.

So yes in this case it is calling function eq.to.Hor()

Still have to get used to the interpreter languages, I did not 'source' that R-file and then R can't find it;-) But now I get another error (eq2horFS not found, while I can call it myself!) so I must have something wrong in my code (I don't get that error using your R code). So working on it;-).

By the way about the color. I found an error in the SIMBAD search engine (they now repaired that), but I also asked them which of the two: 'B-V' (Color Index) or Spectral Class is best to use as proxy to naked eye color experience on Earth. No answer yer, but do you have an answer to that question? For me it is important in determining what I need to ask from SE-authors.

All the best,

Victor

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/f-silva-archaeo/skyscapeR/issues/5#issuecomment-424660605, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASTOUi8mvgGbND4Qe9CqfrGruyqEdSU5ks5ue1JJgaJpZM4W5moB.

vreijs commented 5 years ago

I have indeed that CSIRO link, I also asked them the same question (beside the SIMBAD people). I personalty also though about the 'B-V' (as V means visual;-), but just to be sure... Will inform you what the experts will say.

All the best,

Victor

On 26 September 2018 at 11:22, Fabio Silva notifications@github.com wrote:

That’s odd. Hope you can sort that.

Regarding B-V or Spectral class, I’m sure you are familiar with this: http://www.atnf.csiro.au/outreach/education/senior/ astrophysics/photometry_colour.html

So maybe B-V is more useful since it encapsulates more information than mere spectral class.

Fabio Silva, PhD

Research Associate, UCL Institute of Archaeology

Tutor, Sophia Centre for the Study of Cosmology in Culture, University of Wales Trinity Saint David

Secretary, European Society for Astronomy in Culture (SEAC)

Co-Founder and Co-Editor, Journal of Skyscape Archaeology< http://equinoxpub.com/JSA> (JSA)

Website/Blog: skyscaper.nethttp://www.skyscaper.net. Twitter: @fsilva_archaeohttps://twitter.com/fsilva_archaeo

On 26 Sep 2018, 12:09 +0200, Victor Reijs notifications@github.com, wrote: On 26 September 2018 at 07:49, Fabio Silva notifications@github.com wrote:

parApply takes a function, in this case eq.to.Hor, and applies it to all elements of X using parallelisation.

So yes in this case it is calling function eq.to.Hor()

Still have to get used to the interpreter languages, I did not 'source' that R-file and then R can't find it;-) But now I get another error (eq2horFS not found, while I can call it myself!) so I must have something wrong in my code (I don't get that error using your R code). So working on it;-).

By the way about the color. I found an error in the SIMBAD search engine (they now repaired that), but I also asked them which of the two: 'B-V' (Color Index) or Spectral Class is best to use as proxy to naked eye color experience on Earth. No answer yer, but do you have an answer to that question? For me it is important in determining what I need to ask from SE-authors.

All the best,

Victor

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/f- silva-archaeo/skyscapeR/issues/5#issuecomment-424660605, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ ASTOUi8mvgGbND4Qe9CqfrGruyqEdSU5ks5ue1JJgaJpZM4W5moB.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/f-silva-archaeo/skyscapeR/issues/5#issuecomment-424664337, or mute the thread https://github.com/notifications/unsubscribe-auth/AQa6FqRNIt4y0EsIO1ZmfoiVRYipZFYGks5ue1WDgaJpZM4W5moB .