search

f / delorean

An Agnostic, Complete Flux Architecture Framework
749 stars 40 forks source link

Fixed exports for requirejs modules. #58

Closed darkyen closed 9 years ago

darkyen commented 9 years ago

Fixes #55 a bug which wouldn't let requirejs import modules exported by requirements.js

f commented 9 years ago

Thanks! :+1:

darcyadams commented 9 years ago

This PR breaks Delorean when used Browserify! The below line fires as typeof define === 'function' && define.amd evaluates false. DeLorean is then undefined, which causes an Uncaught ReferenceError.

Will submit a fix shortly. but we need to do a better job testing PRs in the future.

else {
  window.DeLorean = DeLorean;
}