1.0.0 - Githubissues

f / vue-wait

Complex Loader and Progress Management for Vue/Vuex and Nuxt Applications

MIT License

2k stars 101 forks source link

1.0.0 #31

Closed f closed 6 years ago

f commented 6 years ago

v1.0.0

A complete rewrite, more extensible.
Readable and better code.
Update to Webpack 4
Remove built-in loaders. Maybe we can create another repository including custom spinners.
Remove width and height props.
Strict props.
isLoading supports matcher now.
Rename registerComponents to registerComponent
Added accessorName option to change $vueLoading key.
Removed createActionHelpers, use mapLoadingActions or wrapLoading instead.

f commented 6 years ago

@sky-code I'm in rewriting progress. Can you please review?

f commented 6 years ago

Diff view is untrackable, please pull and view code on your editor :)

Koc commented 6 years ago

Code is much better readable now. Can you fix #28 also before 1.0, please?

And WDYT about repository rename? To vue-loading (and remove paragraph about misleading about Vuex).

f commented 6 years ago

I think #28 is fixed with vuexModuleName option. Now no named property is hardcoded, everything is configurable.

I'm thinking about renaming the project but vue-loading is already registered. Maybe we can find another fancy name.

Koc commented 6 years ago

I think #28 is fixed with vuexModuleName option. Now no named property is hardcoded, everything is configurable.

So should I use different vuexModuleName for each Vue instance? If yes - it doesn't sove issue, because we need share same module between different instances.

f commented 6 years ago

Added some useful directives. https://github.com/f/vuex-loading/pull/31/commits/ec2db9d3fd907e0db695934224ab381e46891fe1