f1-2019-results / desktop-client

0 stars 0 forks source link

Linting not working in actions #2

Closed FINDarkside closed 4 years ago

FINDarkside commented 4 years ago

Eslint doesn't emit any errors when linting in actions. Works fine locally.

FINDarkside commented 4 years ago

Seems to emit warnings just fine though.

FINDarkside commented 4 years ago

Seems like it works on windows but not on linux.

See linux vs windows builds.

FINDarkside commented 4 years ago

Build where same steps fail on windows (like it should), but passes with ubuntu. Ubuntu build is not just missing errors, it's also missing warnings from src\parseDump.ts and src\index.ts.

FINDarkside commented 4 years ago

Reopened, now it doesn't work on windows. 😅 No files matching the pattern "'./src/**/*.ts'" were found.

FINDarkside commented 4 years ago

Using double quotes instead of single quotes seems to fix it for windows.

FINDarkside commented 4 years ago

Fixed with 9d7abd6cf07873f7d90ba4242d080f6462510a08