search

f111fei / react-native-unity-demo

103 stars 80 forks source link

Update Build.cs to work with changes in Unity 2018 #6

Closed wezzle closed 6 years ago

wezzle commented 6 years ago

Because of some changes in the Unity 2018 version the Build.cs file was no longer working, this PR uses the new BuildResult to check if the build was successful.

I've also taken the liberty to change the MenuItem shortcuts to: cmd+alt+a (Android) and cmd+alt+i (iOS) Because of the overlap of cmd+a for the select all purpose.

f111fei commented 6 years ago

Thanks. But it seems incompatible with a low version.

wezzle commented 6 years ago

I'm afraid it's not possible to fix this with backward compatibility as the Unity editor checks the type of the report (or string in 2017) and you, therefore, cannot match it against a different type.

Perhaps it would be a good solution to accept this PR on a different branch (for example unity-2018) and make a reference in the readme or build.cs on the master branch to the 2018 version so people may know where to find it?

f111fei commented 6 years ago

@wezzle Good idea. Can you modify the PR and readme again?