search

f1rehead / SlideshowSE

Free, easy to use plugin to integrate slideshows into your WordPress site. A fork of the original project from Stefan Boonstra.
https://wordpress.org/plugins/slideshow-se/
0 stars 0 forks source link

2.5.18 broken widget #5

Open seema84 opened 3 months ago

seema84 commented 3 months ago

Since the last update, my slideshow widget is no longer displayed correctly tt12

seema84 commented 3 months ago

I also get a critical error tt44

f1rehead commented 3 months ago

I'm looking into the issue. It appears to be two things and the first is pretty trivial. For me, the critical error appears to be resolved when I empty the trash (Slideshows > Trash > Delete Permanently). Can you try that and see if that resolves the critical error?

seema84 commented 3 months ago

There are no slideshows in my trash.

f1rehead commented 3 months ago

That's somewhat disappointing. I think I see the problem and will put out a new release in a few hours. Let me know if it fixes everything for you.

seema84 commented 3 months ago

So when i update it manually i get a critical error when activating the plugin. Worpdress does not yet offer the update

f1rehead commented 3 months ago

 Do you have access to your log files? All three of my sites are running the new version without any problem. I wasn’t able to see the critical error so I went through the code looking for problems and fixed anything I thought could be a problem. On Jul 4, 2024, at 06:37, seema84 @.***> wrote: So when i update it manually i get a critical error when activating the plugin. Worpdress does not yet offer the update

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

seema84 commented 3 months ago

Maybe it's just me, I just swapped the plugin folders. Why is the update not offered on https://wordpress.org/plugins/slideshow-se/#developers? At least the change is listed there. But the download is not possible there.

seema84 commented 3 months ago

error

seema84 commented 3 months ago

The block folder seems to be missing here (https://github.com/f1rehead/SlideshowSE/releases/tag/2.5.19). I have now copied it from the old version into the folder. So at least the plugin is loaded.

This error has now been fixed. But the widget is not always displayed incorrectly.

I also get a critical error tt44

f1rehead commented 3 months ago

You can’t just copy a plugin folder In the Gutenberg era. Plugins have to be installed either by uploading a zip file or using the plugin store so that Wordpress can create the block folder. If you have access to the command line, drill down to the plugin folder and type ‘npm run build’ to create the block folder. I’m not sure why 2.5.19 isn’t installable from the Wordpress website. It should be automatic when I create a new release. There isn’t anything that I do to make it happen. Unfortunately I’m on a camping holiday and my internet access is very poor. I will be back on Saturday and can take a look then. Maybe revert to 2.5.17 until I figure out the issue. On Jul 4, 2024, at 14:37, seema84 @.***> wrote: The block folder seems to be missing here (https://github.com/f1rehead/SlideshowSE/releases/tag/2.5.19). I have now copied it from the old version into the folder. So at least the plugin is loaded. This error has now been fixed. But the widget is not always displayed incorrectly.

I also get a critical error

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

seema84 commented 3 months ago

You can’t just copy a plugin folder In the Gutenberg era. Plugins have to be installed either by uploading a zip file or using the plugin store so that Wordpress can create the block folder. If you have access to the command line, drill down to the plugin folder and type ‘npm run build’ to create the block folder. I’m not sure why 2.5.19 isn’t installable from the Wordpress website. It should be automatic when I create a new release. There isn’t anything that I do to make it happen. Unfortunately I’m on a camping holiday and my internet access is very poor. I will be back on Saturday and can take a look then. Maybe revert to 2.5.17 until I figure out the issue. On Jul 4, 2024, at 14:37, seema84 @.> wrote: The block folder seems to be missing here (https://github.com/f1rehead/SlideshowSE/releases/tag/2.5.19). I have now copied it from the old version into the folder. So at least the plugin is loaded. This error has now been fixed. But the widget is not always displayed incorrectly. I also get a critical error —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.>

At least that is what is described everywhere. How can I update with the zip file without reinstalling? When I upload it via "Add new plugin" the already installed plugin is not recognised and a second one with the newer version is simply created.

seema84 commented 2 months ago

In any case, I wish you a great camping holiday.

f1rehead commented 2 months ago

I fixed the issue with links not displaying correctly. Version 2.5.20 is available now with that fix. I still do not see the critical error. Do you have access to your error log file?

seema84 commented 2 months ago

I no longer have a critical error. The widget display also looks better now. Only my customisation has been changed slightly. What is the best way to customise the slideshow widget block?

f1rehead commented 2 months ago

I’m sure you are doing the right thing but I messed something up. Can you explain what is wrong and how it should look?

On Jul 6, 2024, at 5:56 PM, seema84 @.***> wrote:

I no longer have a critical error. The widget display also looks better now. Only my customisation has been changed slightly. What is the best way to customise the slideshow widget block?

— Reply to this email directly, view it on GitHub https://github.com/f1rehead/SlideshowSE/issues/5#issuecomment-2211980519, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADM3IEQDXKYJKQXMU5GXQ33ZLBRZNAVCNFSM6AAAAABKGJY7VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRHE4DANJRHE. You are receiving this because you commented.

seema84 commented 2 months ago

231313

I would like to centre the widget here and have a space at the bottom.

f1rehead commented 2 months ago

That would be something you do in your theme, unless you have added CSS to change the margins around slideshow_container. By default, there is no margin around slideshow_container. You could try to create a custom style and explicitly set slideshow_container { margin: 0 } to make sure that you aren't inheriting any CSS properties from higher in the hierarchy.

seema84 commented 2 months ago

The problem is that the slideshow_container class would change all the slideshows (I have others in other places). The widget unfortunately has no css classes of its own (unless I missed them).

f1rehead commented 2 months ago

You can create a custom style and then use that style for the widget.

On Jul 7, 2024, at 6:23 PM, seema84 @.***> wrote:

The problem is that the slideshow_container class would change all the slideshows (I have others in other places). The widget unfortunately has no css classes of its own (unless I missed them).

— Reply to this email directly, view it on GitHub https://github.com/f1rehead/SlideshowSE/issues/5#issuecomment-2212595921, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADM3IESBAHESGS36ELB57SLZLG5UJAVCNFSM6AAAAABKGJY7VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGU4TKOJSGE. You are receiving this because you commented.

seema84 commented 2 months ago

thank you I have now done that