Jsr305, MinSdk 14

[PaulWoitaschek]

• Updated dependencies and removed unused imports.
• Use a consistent code formatting.
• Replaced the NonNull annotations with jsr305.
• MinSdk 14 en pair with support libraries.

[f2prateek]

This is just changing the code style, not really making it consistent with what was in already in place.

Please break out the other changes into their own PRs as well.

[PaulWoitaschek]

Do you aggree with all changes?

• Min-Sdk14
• Dependency update
• Jsr310?

Can you define the code style somehwere? For example sometimes annotations are wrapping, sometimes they are on the same line

[JakeWharton]

I don't see a motivation to switch to JSR 305.

On Thu, Nov 16, 2017 at 6:36 PM Paul Woitaschek notifications@github.com wrote:

Do you aggree with all changes?

• Min-Sdk14
• Dependency update
• Jsr310?

Can you define the code style somehwere? For example sometimes annotations are wrapping, sometimes they are on the same line

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/f2prateek/rx-preferences/pull/107#issuecomment-345016470, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEayUUPFb7Vdtov2EjDiLKvmwfuk5ks5s3ICQgaJpZM4QgIat .

[PaulWoitaschek]

Well completely everything here is not nullable, so it reduces a lot of boilerplate code.

[JakeWharton]

But it's vastly less supported than support-annotations in the tools we use so you'd be regressing the nullability explicitness.

On Thu, Nov 16, 2017 at 2:12 PM Paul Woitaschek notifications@github.com wrote:

Well completely everything here is not nullable, so it reduces a lot of boilerplate code.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/f2prateek/rx-preferences/pull/107#issuecomment-345031296, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEQVajwwk21nvjzkUfLEIiVGEyaXuks5s3IkFgaJpZM4QgIat .