search

f2prateek / rx-preferences

Reactive SharedPreferences for Android
http://f2prateek.com/2015/10/05/rx-preferences/
Apache License 2.0
1.54k stars 132 forks source link

Android X support #126

Closed justintuchek closed 4 years ago

justintuchek commented 5 years ago

Hey 👋 any rough estimate on when Android X support would be available?

Checked it out in master but hasn't yet been deployed. Anything I can do to help?

f2prateek commented 5 years ago

Can you try the snapshot builds and report if everything looks ok? (instructions would be similar to https://github.com/segmentio/analytics-java#snapshots)

justintuchek commented 5 years ago

Sure - I can do that 👍

Would there be any testing contributions that you would find helpful for verification of future releases? Maybe something in Espresso? (realizing that blows up the simplicity of the current testing pipeline and Travis)

f2prateek commented 5 years ago

I feel reasonably confident about the unit tests in place. I'm not sure how much value espresso/UI tests would add to this library, but would be open to it if there's a strong reason.

Asking for manual verification in this case mostly as a sanity check, because this change in particular changed a lot of the tooling that could cause issues depending on the build environment of your app.

technoir42 commented 4 years ago

@f2prateek no issues with 2.0.1-beta1, although it would be great to finally see a stable release with AndroidX.

f2prateek commented 4 years ago

Thanks for the reminder - just cut release 2.0.1 promoting the changes from the beta to stable. Should be available shortly.