search

f3-factory / fatfree-core

Fat-Free Framework core library
GNU General Public License v3.0
206 stars 89 forks source link

Some suggestions #300

Open soyleung opened 4 years ago

soyleung commented 4 years ago

Best work will doing this Framework, i find a good idea form https://github.com/n0nag0n/fatfree-swoole, yes, it is good. but this diea is extends on \Base, i dont try it work on Ws, if it work on Ws will Stable. This will be the idea of a milestone.

KOTRET commented 4 years ago

Sorry, I don't get the purpose of your suggestion. The code in posted link just strips the hive initialization, which is - of course - faster, but lacks of some features . Also the output obviously is not the same. So what is your issue about?

ikkez commented 4 years ago

I guess it's just a reference for a swoole implementation that works and we could keep that in mind for further refactorings

soyleung commented 4 years ago

I guess it's just a reference for a swoole implementation that works and we could keep that in mind for further refactorings

yes!!! good, i try it, and to do something test with it. I refer to him and modify his structure. Give up the changes he has to make to the core. He does a good job and is quite outstanding. I will upload my code for reference.

soyleung commented 4 years ago

https://github.com/n0nag0n/fatfree-swoole/issues/1#issuecomment-640148509 Base __Clone class is prohibited, now. I don't know what to think. Now we must be in CLI clone Base, clone should be in CLI, at least let go. This is my idea and suggestion. I Try to and code:$this-hive['CLI'] after $ref->iscloneable() in recursive class to do together judgement. God, or what good advice for me? Tks!!!!

soyleung commented 4 years ago

The code has been updated. Please help me. https://github.com/soyleung/fatfree-swoole

n0nag0n commented 4 years ago

@KOTRET @ikkez I know @soyleung tries his (her?) best to communicate in english, but his first language is Chinese. He would be a GREAT asset because swoole docs are more fleshed out in chinese than they are in english.