search

f32c / arduino

FPGArduino source
http://www.nxlab.fer.hr/fpgarduino
68 stars 44 forks source link

Added posedge1 board definitions #20

Closed mhaghighi closed 7 years ago

mhaghighi commented 8 years ago

board definitions for posedge-one FPGA development board added to board.txt

emard commented 8 years ago

OK but seems you are patching wrong file this you patched is not boards manager but for manual installation and it's obsolete arduino/hardware/fpga/f32c/boards.txt

the new boards manager file that does auto-install is this arduino/hardware/fpga/f32c/tools/boards-manager/boards.txt

can you redo your patch to change above file? Or separate this into 2 pull requests, one is adding your board, other is updating and fixling obsolete boards.txt

mhaghighi commented 8 years ago

Sorry, I forgot! I just applied the patch to the right file.

emard commented 8 years ago

HI

No problem I understand this github sometimes sucks :) your pull request would still modify old files so I manually isolated only related patch and applied it to f32c/arduino

check out if that's what you wanted now

you are also welcome to fork f32c/f32c and add support for your boards (toplevel and project files) so I can add them too

watch out glue_bram.vhd slightly changed

Thanx again for the development effort! Davor

On Wed, Mar 9, 2016 at 9:14 PM, mhaghighi notifications@github.com wrote:

Sorry, I forgot! I just applied the patch to the right file.

— Reply to this email directly or view it on GitHub https://github.com/f32c/arduino/pull/20#issuecomment-194488287.

emard commented 8 years ago

I updated boards manager online there are your latest changes, check it out

On Wed, Mar 9, 2016 at 10:08 PM, Davor Emard vordah@gmail.com wrote:

HI

No problem I understand this github sometimes sucks :) your pull request would still modify old files so I manually isolated only related patch and applied it to f32c/arduino

check out if that's what you wanted now

you are also welcome to fork f32c/f32c and add support for your boards (toplevel and project files) so I can add them too

watch out glue_bram.vhd slightly changed

Thanx again for the development effort! Davor

On Wed, Mar 9, 2016 at 9:14 PM, mhaghighi notifications@github.com wrote:

Sorry, I forgot! I just applied the patch to the right file.

— Reply to this email directly or view it on GitHub https://github.com/f32c/arduino/pull/20#issuecomment-194488287.

mhaghighi commented 8 years ago

Thank you emard, In board.txt there are two different set of board definition for posedge_one. The first set of defenition (Line 662 to 699) have to be omitted.

mhaghighi commented 8 years ago

Please check out my recent commit, I have undone my changes to old board.txt file and updated board definitions to the new board manager file.

emard commented 8 years ago

OK! I'll check that and apply

On Fri, Mar 11, 2016 at 11:16 AM, mhaghighi notifications@github.com wrote:

Please check out my recent commit, I have undone my changes to old board.txt file and updated board definitions to the new board manager file.

— Reply to this email directly or view it on GitHub https://github.com/f32c/arduino/pull/20#issuecomment-195307955.

emard commented 8 years ago

this fork has conflicts

it would be cleaner if you remove curennt fork from git and create new one with only latest changes I'm also not git expert it seems most simple way to do it clean

emard commented 8 years ago

HI

I manually removed duplicate hope that's the correct one but who knows, please try and let me know where we are at now

On Sat, Mar 12, 2016 at 11:07 AM, Davor Emard vordah@gmail.com wrote:

OK! I'll check that and apply

On Fri, Mar 11, 2016 at 11:16 AM, mhaghighi notifications@github.com wrote:

Please check out my recent commit, I have undone my changes to old board.txt file and updated board definitions to the new board manager file.

— Reply to this email directly or view it on GitHub https://github.com/f32c/arduino/pull/20#issuecomment-195307955.

mhaghighi commented 8 years ago

HI,

Thank you for your efforts. It's OK. BTW, I am still working on improving the bootloader and adding new features to it. As soon as it becames ready, I will send a pull request to f32c/f32c repo and f32c/arduino as well.

emard commented 8 years ago

HI

You should re-create your git repository to resolve branch conflicts

you don't have to introduce addone option, but use already availabe SOC option to swich between the different bootloaders

see how it is done with ulx2s

emard commented 7 years ago

pull request too old, we changed many things and I'm not sure will it work for recent fpgarduino

if this or similar changes for your board is still applicable please re-send a new pill request related to fresh f32c/arduino tree