search

f3ath / cider

Tools for Dart package maintainers
https://pub.dev/packages/cider
MIT License
101 stars 17 forks source link

Support for YANKED releases #39

Closed clragon closed 1 year ago

clragon commented 1 year ago

As of right now, it seems that Cider fails to parse releases which have been YANKED. The section about YANKED releases on keep a changelog states the following:

image

When running Cider, the following exception is thrown:

> cider log added 'some changes'
Unhandled exception:
FormatException: Invalid date format
2021-11-25 [YANKED]
#0      DateTime.parse (dart:core/date_time.dart:347:7)
#1      _release (package:change/src/parser.dart:53:26)
#2      parseChangelog (package:change/src/parser.dart:28:23)
#3      ChangelogService.read (package:cider/src/service/changelog_service.dart:84:36)
#4      ChangelogService.addUnreleased (package:cider/src/service/changelog_service.dart:57:17)
#5      ChangelogService.install.<anonymous closure> (package:cider/src/service/changelog_service.dart:21:31)
#6      Cider.run (package:cider/src/cider.dart:70:35)
<asynchronous suspension>
clragon commented 1 year ago

While working in this issue, it would probably also be useful to have a command to yank a release. Perhaps simply cider yank [<version>].

f3ath commented 1 year ago

In YAML, the square brackets denote links. I'm wondering what link you think should [YANKED] be pointing to.

clragon commented 1 year ago

fantastic question to which I dont exactly have an answer for. have the keep-a-changelog writers forgotten about it? 🤔 the keep-a-changelog website doesnt have subheaders, so we cant link to the YANKED section...