search

f3d-app / f3d

Fast and minimalist 3D viewer.
https://f3d.app
BSD 3-Clause "New" or "Revised" License
2.54k stars 182 forks source link

Use PBR Neutral tone mapping #1464

Closed Meakk closed 1 week ago

Meakk commented 3 weeks ago

@mwestphal for information a recent change in VTK broke one test on macos ARM.
I'll try to bissect to find the commit, but I suspect it's one of this MR: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11196

mwestphal commented 3 weeks ago

@mwestphal for information a recent change in VTK broke one test on macos ARM. I'll try to bissect to find the commit, but I suspect it's one of this MR: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/11196

This MR is a backport MR to release, I dont see how it could have broke anything since we use master.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.64%. Comparing base (185e095) to head (54dbfa8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1464 +/- ## ========================================== - Coverage 96.64% 96.64% -0.01% ========================================== Files 103 103 Lines 7742 7741 -1 ========================================== - Hits 7482 7481 -1 Misses 260 260 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.