search

f3d-app / f3d

Fast and minimalist 3D viewer.
https://f3d.app
BSD 3-Clause "New" or "Revised" License
2.54k stars 182 forks source link

UserRenderPass: Fix an inverted assert #1497

Closed mwestphal closed 4 days ago

mwestphal commented 4 days ago

@snoyer please review

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.78%. Comparing base (f7c4796) to head (9913cd2). Report is 194 commits behind head on release.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release #1497 +/- ## =========================================== + Coverage 96.41% 96.78% +0.36% =========================================== Files 131 105 -26 Lines 8042 7831 -211 =========================================== - Hits 7754 7579 -175 + Misses 288 252 -36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

snoyer commented 4 days ago

does make the tests pass locally