search

f3d-app / f3d

Fast and minimalist 3D viewer.
https://f3d.app
BSD 3-Clause "New" or "Revised" License
2.83k stars 204 forks source link

`--dry-run` option is not working #1637

Open mwestphal opened 3 weeks ago

mwestphal commented 3 weeks ago

Describe the bug F3D usually uses a config file, but there is an option to disable this behavior, --dry-run. It seems to be non-functionnal currently

To Reproduce Steps to reproduce the behavior, using a built f3d with BUILD_TESTING enabled:

  1. Open the file using `f3d --config=config_build --dry-run --verbose
  2. F3D appears with axis visible, it should not
  3. Check the output, a config file is read

Expected behavior Config file should not be read

Additional context in F3DStarter.cxx:655, although the comment says that dry-run is being checked, its actually not. Add the check here by checking the cli option and position the boolean accordingly. Also add a test for it in application/testing/CMakeLists.txt

snoyer commented 3 weeks ago

Would this be the right time to rename this argument to --no-config or something? --dry-run is used in many CLI applications to mean "run as normal but don't actually write/change anything" so it's a bit confusing (F3D's --no-render is closer to what --dry-run usually means)

mwestphal commented 3 weeks ago

Good point @snoyer

Yogesh9000 commented 2 weeks ago

Is this issue still open? If it is I would like to work on it.

mwestphal commented 2 weeks ago

It is open!

mwestphal commented 2 weeks ago

Hum, since you are working on another issue, I'd like to keep this one open for other developpers with no experience on the project if thats ok

Yogesh9000 commented 2 weeks ago

sure thats fine

rehanganapathy commented 2 weeks ago

Hey there, this looks interesting, if no one else is working on it, can i pick it up? Thank you so much! @mwestphal

mwestphal commented 2 weeks ago

Sounds good! @rehanganapathy , go for it :)