f3d-app / f3d

Fast and minimalist 3D viewer.
https://f3d.app
BSD 3-Clause "New" or "Revised" License
2.72k stars 195 forks source link

Improve Alembic reader #913

Open mwestphal opened 1 year ago

mwestphal commented 1 year ago

Is your feature request related to a problem? Please describe. Since #138 was closed, F3D has been supporting alembic file format, however the support is fairly limited, let's improve it.

Missing features:

mwestphal commented 1 year ago

@Meakk : Since you already looked at that, which feature should we had in the list above ?

@gerroon @nyue : Please let me know your thougts on this

Meakk commented 1 year ago

Normals, texture coordinates, and animation.
Please note that in the case of animation, there's no skinning as far as I know. It's only time-dependent buffers so quite easy to support.

gerroon commented 1 year ago

I think the current alembic reader shows objects in the center of the world, it might be the animation data thing.

mwestphal commented 1 year ago

@gerroon : Do you have an example file ?

mwestphal commented 12 months ago

FYI VTK is currently adding a vtkAlembicExporter, we could hope our importer could be integrated in VTK and improved by the VTK community.

nyue commented 12 months ago

Apologies, I have been away for sometime.

I am happy to help out on the Alembic specific, especially with getting (1) Normal (2) Texture Coordinate into/out-of Alembic.

However, I am unable to find the time to be able to re-wrap my head around F3D specifics.

For example, someone can ask "please provide a C++ example to query geometry normals from an Alembic file", that type of question I am able to find the time to put them together. If it becomes the wider question about how that will transfer to F3D, I will be too slow to be productively helpful as I have to dive into F3D itself and understand the underlying design and best practices of F3D.

If the above arrangement (me helping someone familiar with F3D), yes, I can participate.

Kind regards.

mwestphal commented 12 months ago

@nyue of course we can help, do you use discord ? https://discord.f3d.app

nyue commented 12 months ago

@mwestphal I do use Discord and I have now joined f3d on discord.

mwestphal commented 9 months ago

Partially done in https://github.com/f3d-app/f3d/pull/1069

mwestphal commented 9 months ago

@Meakk do you still plan to do the animation part ?

Meakk commented 9 months ago

Yes I will. I have animated files to work on.

mwestphal commented 5 months ago

done in #1340

Meakk commented 5 months ago

Let me reopen that issue. I see 2 points to improve:

mwestphal commented 5 months ago

good points, I've added them on top.

mwestphal commented 5 months ago

But its a reader, not an importer, so no textures supported anyway ?

Meakk commented 5 months ago

Texture coordinates are supported but AFAIK there's no material description described by the format itself. Alembic is mainly used to export baked simulation.

mwestphal commented 5 months ago

Ha, got it.

gerroon commented 5 months ago

Alembic should support polygon tags to define where the materials are applied but it is a format that wont really support texture/material data, most users of alembic would expect to have material previews with alembic.

Meakk commented 5 months ago

@gerroon what do you mean by material previews? Some kind of texture placeholder like a checkboard?

gerroon commented 5 months ago

@gerroon what do you mean by material previews? Some kind of texture placeholder like a checkboard?

What I meant is that the alembic users would know the limitation, it is a format for specialized use case really.