search

f3d-app / f3d

Fast and minimalist 3D viewer.
https://f3d.app
BSD 3-Clause "New" or "Revised" License
2.57k stars 182 forks source link

Rework background options naming #918

Open mwestphal opened 12 months ago

mwestphal commented 12 months ago

Describe the bug Background options for F3D are named a bit wldly, it would be nice to rename them on a major version change

Current names

  1. no-background -> AppOptions
  2. bg-color -> render.background.color
  3. hdri -> render.background.hdri
  4. blur-background -> render.background.blur
  5. blur-coc -> render.background.blur.coc
mwestphal commented 12 months ago

Suggestions:

  1. background-none -> AppOptions
  2. background-color -> render.background.color
  3. hdri -> render.background.hdri.file
  4. background-blur -> render.background.blur.enable
  5. backgground-blur-coc -> render.background.blur.coc

Bonus:

  1. hdri-hide -> render.background.hdri.hide
mwestphal commented 12 months ago

wdyt @Meakk @snoyer ?

Da3n0n commented 12 months ago

speaking of BG Color is there a way to currently set the default background color of the Viewport for every file that opened in f3d Permanently ? :D

Da3n0n commented 12 months ago

or a default hdri that is loaded with every file thats oepened would be nice aswell :D

mwestphal commented 12 months ago

You can do that easily using config files , see this: https://f3d.app/doc/user/CONFIGURATION_FILE.html

Da3n0n commented 11 months ago

thank you so much never copped this , really good stuff :D :P still think would be nice to have option for changing constant 3 vector in side f3d windows or even bg color black to white 0>1 with adjustment like light increase and decrease but for BG color :P

mwestphal commented 11 months ago

constant 3 vector in side f3d windows

What do you mean ?

even bg color black to white 0>1 with adjustment like light increase and decrease but for BG color

Interesting idea

Could you open dedicated issues for that ? I'm afraid it's not related to options naming.

Da3n0n commented 11 months ago

@mwestphals sorry i didnt make it clear i will open a new issue and put the clarification with it there as its related to the BG color aswell and similar idea.

mwestphal commented 11 months ago

Partially addressed in #932

mwestphal commented 11 months ago

Remaining options to rename:

Current names

  1. no-background -> AppOptions
  2. bg-color -> render.background.color
  3. blur-background -> render.background.blur
  4. blur-coc -> render.background.blur.coc