search

f3d-app / f3d

Fast and minimalist 3D viewer.
https://f3d.app
BSD 3-Clause "New" or "Revised" License
2.85k stars 205 forks source link

F3D final alpha blending is incorrect #968

Closed Meakk closed 4 months ago

Meakk commented 1 year ago

A proper alpha blending must pre-multiply the colors by the alpha value and do the compositing in the linear color space.
A comment have been added in the render pass code. More investigation is needed.

mwestphal commented 1 year ago

Do you have a screenshot to illustrate the bug ? I have no idea how to recognise it.

Meakk commented 1 year ago

Well, it's hard to notice the issue, but the code is incorrect.
I'll fix it and post image comparison.

mwestphal commented 10 months ago

Any news on this @Meakk ?

Meakk commented 10 months ago

It's not urgent, I don't plan to work on it anytime soon

mwestphal commented 9 months ago

@Meakk care to improve the issue description so that help-wanted label could be added ?

Meakk commented 9 months ago

I need time to clarify that, what about a label workflow: investigation or workflow: research?

mwestphal commented 9 months ago

Indeed, that seems needed, I will finish my current pass on issues and think about a complete workflow.