search

f3oall / awesome-notifications

Lightweight JavaScript Notifications Library
https://f3oall.github.io/awesome-notifications/
MIT License
292 stars 40 forks source link

Comma between buttons on confirmation popup #26

Closed SpaceCudet closed 4 years ago

SpaceCudet commented 5 years ago

The confirmation popup displays a comma between the Ok and Cancel buttons - this can be seen in the example in the documentation.

Steps to reproduce the behavior:

  1. Go to Popups: Confirmation documentation
  2. Click on first 'Run Example" button
  3. See comma between the Ok and Cancel buttons

image

Looking at the code in popup.js, the buttons are created in an array which is appended to a string using array.join(). The default delimiter for join is a comma, so the solution may be to use a parameter of an empty string: buttons.join('').

Nickfrm commented 4 years ago

Fixed in v3.0.4 Thanks for your feedback