search

f3rno / bfx-hf-ui

Apache License 2.0
0 stars 2 forks source link

Feature: Notify explanatory minimum size error #51

Closed f3rno closed 4 years ago

f3rno commented 4 years ago

Currently if an AO fails due to a minimum-order-size error, we don't notify the user.

This needs to be improved to state the minimum size for the market.

JacobPlaster commented 4 years ago

Just to confirm, no error message is received on the UI side:

image

JacobPlaster commented 4 years ago

Log output from DM chat:

2020-02-24T09:45:12.649Z bfx:hf:algo:bfx-iceberg:1582536393313 order successfully submitted: EXCHANGE LIMIT 0.000999 @ 8000 ACTIVE
2020-02-24T09:45:12.649Z bfx:hf:algo:bfx-iceberg:1582536393313 Invalid order: minimum size for BTCUSD is 0.0006
2020-02-24T09:45:12.649Z bfx:hf:algo:ao-host triggering errors:minimum_size for AO bfx-iceberg [gid 1582536393313]
2020-02-24T09:45:12.650Z bfx:hf:algo:bfx-iceberg:1582536393313 received minimum size error for order: 0.000001 @ 8000
2020-02-24T09:45:12.650Z bfx:hf:algo:bfx-iceberg:1582536393313 stopping order...
2020-02-24T09:45:12.650Z bfx:hf:algo:bfx-iceberg:1582536393313 emit exec:order:cancel:all
2020-02-24T09:45:12.652Z bfx:hf:algo:ao-host saved AO 1582536393313
2020-02-24T09:45:12.652Z bfx:hf:algo:bfx-iceberg:1582536393313 emit exec:stop
f3rno commented 4 years ago

Ah, my mistake, I remembered a red error notification. Will update the issue.

EDIT: The red notification is for atomic orders