f4d / gmail-delay-send

Automatically exported from code.google.com/p/gmail-delay-send
0 stars 0 forks source link

tomorrow at 10:00 is parsed incorrectly #89

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Go to the Gmail Delay Send Settings page.
2. Under "Test a date or time" type "tomorrow at 10:00"
3. Click "Parse Date"

What is the expected output? What do you see instead?
1. Expected: Thu Jul 11 2013 10:00
2. Actual:   Thu Jul 11 2013 00:00

What version of the product are you using? On what operating system?
1. Gmail Delay Send Web thingy (version 8)

Original issue reported on code.google.com by guillaum...@gmail.com on 10 Jul 2013 at 7:33

GoogleCodeExporter commented 8 years ago
Hello guillaumehanique,

Gmail Delay Send uses a library called datejs to parse the dates. It would seem 
that something like 'tomorrow 10:00' would be the first thing it would support 
but it doesn't seem to  :-(

I've made some very simple modifications to the source code 
(https://code.google.com/p/gmail-delay-send/source/browse/v2/src/datejs#2935) 
but haven't made time to fix something like this.

Patches to the upstream project (datejs.com) or this project are welcome!

Figuring out what datejs supports and doesn't support is tricky: 
https://code.google.com/p/gmail-delay-send/wiki/GmailDelaySendOptions_8#Test_a_d
ate_or_time

Original comment by blairk...@gmail.com on 11 Jul 2013 at 8:13

GoogleCodeExporter commented 8 years ago
I looked at the DateJS project. The problem is known since 2008 and still
exists...
Well, absolute times are more reliable anyway, so I'll just use that.

Thanks!

Original comment by guillaum...@gmail.com on 12 Jul 2013 at 9:51