search

f4exb / cm256cc

Fast GF(256) Cauchy MDS Block Erasure Codec in C++
GNU General Public License v3.0
23 stars 8 forks source link

gf256.h nullptr should not be defined #13

Closed f4exb closed 4 years ago

f4exb commented 4 years ago

This is very wrong and should be removed: https://github.com/f4exb/cm256cc/blob/master/gf256.h#L108

Tx-Charlie commented 4 years ago

Oh, em.. That issue make sdrangel can not be build on Qt 5.12 & Qt 5.14.

Sry that I post that issue on a exsited post couldn't find LimeSDR device...... Sould I open a new issue to mention it? (Can not build on new version of Qt (5.14)) ?

And cmake may need set c++ standrad as c++11, cause nullptr is c++11's feature.

f4exb commented 4 years ago

Good poin!! Will add these lines to CMakeLists.txt:

set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD_REQUIRED ON)