Closed gvanem closed 6 years ago
Trying to build using MSVC (to use it in SDRangel), I hit problems with variable length arrays. Like here:
CM256::cm256_block txDescriptorBlocks[params.OriginalCount+params.RecoveryCount];
(in unit_test/cm256_test.cpp). Although not strictly needed for a cm256cc.lib, i would be nice that these could be written as:
unit_test/cm256_test.cpp
cm256cc.lib
CM256::cm256_block *txDescriptorBlocks = new CM256::cm256_block [params.OriginalCount+params.RecoveryCount];
instead. An with a delete[] txDescriptorBlocks; on exit.
delete[] txDescriptorBlocks;
Sure, that's better
Done in v1.0.0
Yes done in commit df0e21b actually
Trying to build using MSVC (to use it in SDRangel), I hit problems with variable length arrays. Like here:
(in
unit_test/cm256_test.cpp
). Although not strictly needed for acm256cc.lib
, i would be nice that these could be written as:instead. An with a
delete[] txDescriptorBlocks;
on exit.