f4exb / cm256cc

Fast GF(256) Cauchy MDS Block Erasure Codec in C++
GNU General Public License v3.0
23 stars 8 forks source link

MSVC and VLAs #4

Closed gvanem closed 6 years ago

gvanem commented 6 years ago

Trying to build using MSVC (to use it in SDRangel), I hit problems with variable length arrays. Like here:

 CM256::cm256_block txDescriptorBlocks[params.OriginalCount+params.RecoveryCount];

(in unit_test/cm256_test.cpp). Although not strictly needed for a cm256cc.lib, i would be nice that these could be written as:

 CM256::cm256_block *txDescriptorBlocks = new CM256::cm256_block [params.OriginalCount+params.RecoveryCount];

instead. An with a delete[] txDescriptorBlocks; on exit.

f4exb commented 6 years ago

Sure, that's better

f4exb commented 6 years ago

Done in v1.0.0

f4exb commented 6 years ago

Yes done in commit df0e21b actually