f4exb / sdrangel

SDR Rx/Tx software for Airspy, Airspy HF+, BladeRF, HackRF, LimeSDR, PlutoSDR, RTL-SDR, SDRplay and FunCube
GNU General Public License v3.0
2.89k stars 434 forks source link

v7: Exclusion of soapy plugins does not work in Windows #1243

Closed f4exb closed 2 years ago

f4exb commented 2 years ago

With v7.0.0-alpha.3 SoapySDR support has been made optional and triggered with the --soapy option on the command line. However this does not work in Windows. When there is no such option the plugins are still loaded. This is because the file name being checked works for Linux only. On Windows:

2022-05-13 14:23:23.774 (D) PluginManager::loadPluginsDir: fileName: inputsoapysdr.dll
2022-05-13 14:23:23.779 (I) PluginManager::loadPluginsDir: loaded plugin inputsoapysdr.dll
...
2022-05-13 14:23:23.896 (D) PluginManager::loadPluginsDir: fileName: outputsoapysdr.dll
2022-05-13 14:23:23.898 (I) PluginManager::loadPluginsDir: loaded plugin outputsoapysdr.dll

But what is being checked is libinputsoapysdr and liboutputsoapysdr. Maybe this is good enough to check just for soapysdr: https://github.com/f4exb/sdrangel/blob/v7/sdrbase/plugin/pluginmanager.cpp#L220

f4exb commented 2 years ago

Fixed in v7.0.0-alpha.4