Problem with multiple audio demods on different devices

[srcejon]

If on Windows we have two SDRs each with a BFM Demod, it seems stopping the second can interfere with playback of the first. To recreate:

• Add two RTL SDR devices
• Add one BFM Demod on each device
• Start acquistion on both devices
• Audio plays properly on both devices
• Stop the second device
• After a few seconds, audio is choppy on first device, and we get messages: AudioFifo::write: (BFMDemod [3:0]) overflow 128 samples BFMDemodSink::feed: 16256/16384 audio samples written
• Restart second device and problem goes away.

Problem doesn't seem to happen if we stop first device rather than the second. Doesn't seem to be a problem on Linux. Doesn't seem to be a problem for NFM or AM Demods.

[srcejon]

AM/NFM demods both delete the baseband object when stop() is called, the BFM Demod doesn't.

 DSPEngine::instance()->getAudioDeviceManager()->removeAudioSink(m_sink.getAudioFifo());

is in the destructor for each of these basebands. This isn't therefore getting called for the BFM demod when stop() is called.

[srcejon]

Actually, it seems the AM and NFM demods do have a problem, it just manifests in a different way. If you just start one device, without having started the other, then wait a few seconds, you'll eventually get AudioFIFO::write overflows.

[srcejon]

The problem with the AM & NFM demods, appears to relate to the fact they call start() from within the Demod's constructor. If I remove those calls to start(), so start() is only called when the device starts, the problem appears to go away.

So it looks like the problem will occur if we have an audio sink connected to the AudioDeviceManager, when the corresponding device isn't running.