search

f4exb / sdrangel

SDR Rx/Tx software for Airspy, Airspy HF+, BladeRF, HackRF, LimeSDR, PlutoSDR, RTL-SDR, SDRplay and FunCube
GNU General Public License v3.0
2.72k stars 421 forks source link

Don't call start() in demod constructors #2104

Closed srcejon closed 1 month ago

srcejon commented 1 month ago

This patch removes the call to start() in the AM, NFM, WFM, BFM, VOR and SSB demods, to fix #2102

The BFM demod also has additional changes so that the baseband and sink are deleted on stop() to ensure the destructor is called disconnecting the audio sink, and brings the code structure in-line with the other demods.

There are a few changes to the NFM, BFM and SSB demod GUI code to account for the baseband/sink not existing all the time.

Also, there's an unrelated change to the SSB GUI that disables AGC settings when AGC is disabled.

Note that the DSDDemod, M17Demod and FreeDVDemod probably also need the change, but let me know if there's any problems with the patch so far.

dforsi commented 1 month ago

This patch removes the call to start() in the AM, NFM, WFM, BFM, VOR and SSB demods, to fix #2101.

typo: this PR is to fix #2102