f4lco / om-parser-stw-potsdam-v2

Connect canteens of the Studentenwerk Potsdam to OpenMensa
3 stars 7 forks source link

URL and parameters have changed #18

Closed felixauringer closed 1 year ago

felixauringer commented 1 year ago

The URL of the stw-potsdam API changed from /essen/unsere-mensen-cafeterien/detailinfos to /essen/unsere-mensen/detailinfos and the query parameters changed slightly. Currently (also in the latest build), requesting a menu feed causes the parser to crash with a JSONDecodeError.
The tests do not show this because of 0b630df1b01d57bd9ce55cd720f7708928b86b1d.

f4lco commented 1 year ago

Oh dear, the commit message says it all. I was tired of opening the build logs just to find out that the old endpoint did not return JSON on a small percentage of days. If the old endpoint 404ed or something, the nightly build job would have started failing, and would eventually have caught my attention.

Thank you for digging up this repo & for figuring all this out 🏅

f4lco commented 1 year ago

I pinged @kaifabian over at https://github.com/kaifabian/om-parser-stw-potsdam-v2/pull/6. He's in charge of deployments 🔧