search

f4pga / prjxray

Documenting the Xilinx 7-series bit-stream format.
https://f4pga.github.io/prjxray-db/
ISC License
755 stars 148 forks source link

review htmlgen #173

Closed mcmasterg closed 3 years ago

mcmasterg commented 5 years ago

Some HTML sections like BRAM have changed after recent commits (think they are broken?). Review after BRAM DB commits to get them into a reasonable state

This will probably start a larger conversation about what a segment means now, and how we should display things. For example, we may want to move to tile only, and drop the original notation of segments (which I think only htmlgen uses right now?)

mithro commented 5 years ago

Looks like it still broken?

image

mithro commented 5 years ago

Segment verse tile?

X-Ray KINTEX7 Database: BRAM0_L
X-Ray ARTIX7 Database: BRAM_L
mcmasterg commented 5 years ago

I'll review it after I finish cleaning up some of the config. FYI there are one or more DB fixes on my bram branch that aren't pushed out. I haven't tried htmlgen since then. In any case IMHO BRAM html output isn't important until we actually have bits there

JohnDMcMaster commented 5 years ago

@tmichalak is looking into this

tmichalak commented 5 years ago

For the record, despite the changes the BRAM_L is still presented in four columns with frames 5 to 25 in each column hidden. This means that it's still different from the visualization on the left shown in the image posted by @mithro in this thread. However, from looking at the code, this seems intentional.

tmichalak commented 3 years ago

It seems the original issue was fixed long time ago. I am closing it for now, we can open new htmlgen related issues if needed.