search

f4z3r / gruvbox-material.nvim

Material Gruvbox colorscheme for Neovim written in Lua
MIT License
32 stars 4 forks source link

Diagnostics groups #18

Closed dot-1q closed 3 months ago

dot-1q commented 3 months ago

This PR adds the Diagnostic highlight groups defined by Neovim: https://neovim.io/doc/user/diagnostic.html I tried to link to previously defined highlights when possible.

Preview of Errors: Before:

Screenshot 2024-05-06 at 17 01 54

After:

Screenshot 2024-05-06 at 17 02 22

Notes: There's no *Ok highlight group, but I assumed this would have the color green. Deprecated and Unnecessary as Grey and Yellow respectively. What's your opinion?

f4z3r commented 3 months ago

@dot-1q thanks for the PR! I will have a look at it, it definitely makes sense to add these 👍🏽

dot-1q commented 3 months ago

Sure! Do you want me to link the Neovim's Diagnostics highlight wiki page in the Changelog, or is text-only fine? I noticed I included the Changelog change in this commit. I'll have to remove it and rebase these commits, and update the Changelog in a different commit, so as to make it follow your commit history on that file. Or, remove the change, and if you merge the pull request with the squash option, it squashes all these commits into one, making it more readable.