Change DiagnosticUnnecessary color

f4z3r / gruvbox-material.nvim

Material Gruvbox colorscheme for Neovim written in Lua

MIT License

32 stars 4 forks source link

Change DiagnosticUnnecessary color #29

Closed dot-1q closed 2 months ago

dot-1q commented 2 months ago

This PR changes the color of the DiagnosticUnnecessary highlight color to one less flashy. I.M.O yellow is too strong for a warning such as this. In Go, this variable needs to be removed, but in other languages (e.g: python), having an unused variable is fine and does not warrant this much flashiness.

Left: Before | Right: After

What do you think @f4z3r?

f4z3r commented 2 months ago

Hi @dot-1q it seems to make sense yes. I am currently on holidays and will review this whenever I get around to it.

Could you add a short phrase in the changelog in the "unreleased" section about this change?

dot-1q commented 2 months ago

Sure thing. Added it in the Changed section.

f4z3r commented 2 months ago

Looks good. Thanks a lot!