Closed jmacd closed 1 year ago
Minor edit for consistency. The use of a pointer to
ptrace.Span
andpmetric.Metric
raises flags about how these optimizers work, and it appears to be unnecessary. Note that these types are pointers under-the-hood anyway, and the optimizer was not using these as reference types.
Yea, I had the intent at some point to remove this inconsistency (and others) but I forgot... Thanks.
Also note: the logs optimizer appears to work differently (slightly), so no change there. (Tangent: why does the logs optimizer use a
*ResScope
where the two others in-line the flattened thing?)
Same thing, don't hesitate to add a todo and I will clean that after my vacations.
Minor edit for consistency. The use of a pointer to
ptrace.Span
andpmetric.Metric
raises flags about how these optimizers work, and it appears to be unnecessary. Note that these types are pointers under-the-hood anyway, and the optimizer was not using these as reference types.Also note: the logs optimizer appears to work differently (slightly), so no change there. (Tangent: why does the logs optimizer use a
*ResScope
where the two others in-line the flattened thing?)