search

f5 / unovis

Modular data visualization framework for React, Angular, Svelte, Vue, and vanilla TypeScript or JavaScript
https://unovis.dev
Apache License 2.0
2.23k stars 43 forks source link

Typo in docs and improvement for vue example in docs. #357

Closed ByMykel closed 6 months ago

ByMykel commented 7 months ago

Hi.

I have noticed that you have an extra greater-than sign (>) in every vue example code:

image

https://github.com/f5/unovis/blob/9b26703f8af50fe91c0c01254c4caed133ecb083/packages/website/docs/utils/code.ts#L125

When I was trying to add a tooltip to my chart, I couldn't find where you got StackedBar.selectors.bar from until I found on another page that you import that from @unovis/ts.

Maybe it would be great to add that to the example code?

image

BTW, I wanted to open a PR but CLA was to much for a small type. So my question is, do I need to sign that to remove a character from the docs?

rokotyan commented 7 months ago

Thanks for pointing this out @ByMykel! Unfortunately the CLA is needed to accept any outside contributions. It's a weird corporate thing we can do nothing about 😔

@zernonia Since you are the creator of the Vue integration, what do you think about re-exporting selectors along with the Vue components? We started doing it in React recently for convenience, e.g.export const VisAreaSelectors = Area.selectors

zernonia commented 7 months ago

Hey @rokotyan . Yeah sure, no prob! 😁