search

f500 / elewant

Other
21 stars 15 forks source link

Move inline JS to file(s) in assets folder #48

Closed jaspernbrouwer closed 7 years ago

jaspernbrouwer commented 7 years ago

Except for the inline javascript. There's a (placeholder) file src/Elewant/FrontendBundle/Resources/assets/js/elewant.js, which is (emtpy, but) already used in Grunt. So I'd suggest to bind the events to to proper classes 🙂 Also, we have jQuery, so no need to manually build anXMLHttpRequest 😉

ramondelafuente commented 7 years ago

This JS was a example in order to prototype the flow of herd management; explicitly not tied to any framework to keep the choice free to whoever was planning to implement these views in the actual application.

I was going to re-write the example page after we had a nice working app. I don't want the example JS to leak into the files we will be using in production.

ramondelafuente commented 7 years ago

(I might not have been very clear that the /example is currently leading the way for a properly built production version)

jaspernbrouwer commented 7 years ago

Got it! 👍